ENH: Support multiline header fields in TCK #1175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattcieslak's initial PR was lost in the refactor by @anibalsolon in #1140. This PR takes the data file shared by @valeriejill, with just the first streamline (zeroed out) to confirm that a header that was failing to be read now can be. I've also added an extra
command_history
line later in the header to ensure that we aggregate duplicate keys instead of overwrite, in response to #957 (comment) by @thijsdhollander.@valeriejill can you confirm that we have permission to publish this file as part of our test data? If not, I think I've learned enough about working with the format to make my own.
@anibalsolon @MarcCote I would appreciate code reviews from you.
Closes #957.