Just INFO not WARNING if heuristic is missing intotoids #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only reproin which provides such handling and in general there should really be no harm -- we already raise exception if subject id is not provided/degenerate, so shold be safe to just inform instead of WARN the user. Closes nipy#783
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 42 42
Lines 4217 4217
=======================================
Hits 3462 3462
Misses 755 755 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only reproin which provides such handling and in general there should really be no harm -- we already raise exception if subject id is not provided/degenerate, so shold be safe to just inform instead of WARN the user.
Closes #783