Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone aware #780

Merged
merged 8 commits into from
Oct 2, 2024
Merged

timezone aware #780

merged 8 commits into from
Oct 2, 2024

Conversation

AlanKuurstra
Copy link
Contributor

addresses #777

Adds capability to handle datetime stripping for all datetimes allowed in the dicom and bids standards.

@yarikoptic
Copy link
Member

dang, I have managed to miss this PR and CI managed to not run test for some reason!
I will attend to it within a few days. If you could rebase or otherwise refresh it to re-trigger the CI, would be appreciated.

@AlanKuurstra
Copy link
Contributor Author

I rebased, CI is awaiting approval from a maintainer.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR! Let's get "zone aware!" ;-)
See individual comments for some minor tune ups requested

heudiconv/utils.py Outdated Show resolved Hide resolved
heudiconv/utils.py Outdated Show resolved Hide resolved
heudiconv/utils.py Outdated Show resolved Hide resolved
heudiconv/utils.py Outdated Show resolved Hide resolved
heudiconv/utils.py Show resolved Hide resolved
heudiconv/tests/test_utils.py Show resolved Hide resolved
heudiconv/dicoms.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (383525d) to head (84a0cfa).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
heudiconv/utils.py 96.15% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   82.13%   82.42%   +0.28%     
==========================================
  Files          42       42              
  Lines        4226     4301      +75     
==========================================
+ Hits         3471     3545      +74     
- Misses        755      756       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanKuurstra AlanKuurstra force-pushed the timezone_aware branch 2 times, most recently from 0df748c to 9f2f51c Compare September 18, 2024 19:19
heudiconv/utils.py Outdated Show resolved Hide resolved
heudiconv/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @AlanKuurstra , let's proceed!

@yarikoptic yarikoptic added the minor Increment the minor version when merged label Oct 2, 2024
@yarikoptic yarikoptic merged commit 0970b86 into nipy:master Oct 2, 2024
9 checks passed
Copy link

github-actions bot commented Oct 2, 2024

🚀 PR was released in v1.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants