-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timezone aware #780
timezone aware #780
Conversation
dang, I have managed to miss this PR and CI managed to not run test for some reason! |
889702c
to
2ecc2c9
Compare
I rebased, CI is awaiting approval from a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR! Let's get "zone aware!" ;-)
See individual comments for some minor tune ups requested
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 82.13% 82.42% +0.28%
==========================================
Files 42 42
Lines 4226 4301 +75
==========================================
+ Hits 3471 3545 +74
- Misses 755 756 +1 ☔ View full report in Codecov by Sentry. |
0df748c
to
9f2f51c
Compare
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
9f2f51c
to
77ba0b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @AlanKuurstra , let's proceed!
🚀 PR was released in |
addresses #777
Adds capability to handle datetime stripping for all datetimes allowed in the dicom and bids standards.