-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, MAINT: Simpler vector params #291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 75.06% 75.02% -0.04%
==========================================
Files 7 7
Lines 2635 2631 -4
Branches 515 514 -1
==========================================
- Hits 1978 1974 -4
Misses 479 479
Partials 178 178 |
Pushed a commit that works around Mayavi/VTK auto-scaling stuff |
Okay, done for now I think. I tweaked the scaling such that it's more robust to data changes |
We are due for a release, so I'll merge this then push out a release unless people object (I think I asked about this already a week or two ago but don't remember...?) |
We can avoid a lot of gymnastics having to do with maximum magnitudes and even scalars by setting the
scale_mode='vector'
in thequiver3d
call.