Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, MAINT: Simpler vector params #291

Merged
merged 6 commits into from
Jun 23, 2020
Merged

MRG, MAINT: Simpler vector params #291

merged 6 commits into from
Jun 23, 2020

Conversation

larsoner
Copy link
Contributor

We can avoid a lot of gymnastics having to do with maximum magnitudes and even scalars by setting the scale_mode='vector' in the quiver3d call.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #291 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   75.06%   75.02%   -0.04%     
==========================================
  Files           7        7              
  Lines        2635     2631       -4     
  Branches      515      514       -1     
==========================================
- Hits         1978     1974       -4     
  Misses        479      479              
  Partials      178      178              

@larsoner
Copy link
Contributor Author

Pushed a commit that works around Mayavi/VTK auto-scaling stuff

@larsoner
Copy link
Contributor Author

Okay, done for now I think. I tweaked the scaling such that it's more robust to data changes

@larsoner larsoner mentioned this pull request Jun 11, 2020
@larsoner
Copy link
Contributor Author

We are due for a release, so I'll merge this then push out a release unless people object (I think I asked about this already a week or two ago but don't remember...?)

@larsoner larsoner merged commit 9e5fe1f into nipy:master Jun 23, 2020
@larsoner larsoner deleted the simpler branch June 23, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant