BUG: Properly clean up on del #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 74.31% 74.45% +0.13%
==========================================
Files 7 7
Lines 2570 2568 -2
Branches 514 513 -1
==========================================
+ Hits 1910 1912 +2
+ Misses 482 480 -2
+ Partials 178 176 -2 |
|
This looks fine, but has @drammock confirmed that it works? I don’t see a linked issue. |
|
Sorry. Yes, confirmed. I probably did so in slack or in a private repo and forgot to report back here. |
|
Great, thanks @drammock |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a bug @drammock hit where memory consumption crept up with multiple
figuse andmlab.options.offscreen=True. Basically we should make sure we close the figures we create, since the offscreen ones can stay open and consume memory.