MRG: Fix scale_data_colormap and add FXAA #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @larsoner, it seems to be fixed now. |
|
thx @larsoner but I have no clue why CIs fail |
|
Because the |
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 74.9% 74.95% +0.04%
==========================================
Files 7 7
Lines 2506 2511 +5
Branches 501 505 +4
==========================================
+ Hits 1877 1882 +5
Misses 454 454
Partials 175 175 |
|
I'll merge since it looks like a +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260.
@hichamjanati can you see if this solves your problem?
I also added a
use_fxaa = Trueto improve rendering quality slightly while I was in there, and fixed where we should have enabled backface culling for the quiver arrows.