MNT: flake8/black/isort → ruff #3185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
0db5166
to
4c464f4
Compare
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
4c464f4
to
c3b1d2a
Compare
effigies
added a commit
that referenced
this pull request
Feb 5, 2024
Follow-up to nipreps/smriprep#397. This should replace #3185 and #3147. I would review this commit-by-commit, and skip c0f2183, which was a pretty safe run of `ruff format` and `ruff --fix`. It's dominated by quote changes, so I would ignore it. Everything else could stand a review.
effigies
pushed a commit
that referenced
this pull request
Mar 22, 2024
Apply some [Repo-Review](https://learn.scientific-python.org/development/guides/repo-review/?repo=nipreps%2Ffmriprep&branch=master) suggestions. I went for the low-hanging fruits, other changes are more invasive and deserve a PR of their own (for example switching flake8/black/isort to ruff in #3185).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Replace flake8, black and isort with ruff.
See https://github.com/orgs/nipreps/discussions/45.