Fix error Concat str + bytes #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Ill let @mattdodge or @bp1222 cast their approval to merge. |
|
@mattdodge ir @bp1222 could you approve this PR for merge? It would really help me in my work here :) |
|
Sorry @jamesleesaunders and @matheuscandido, I no longer work for niolabs and am unable to merge to this repository as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the error, when you do not insert all the arguments in the function and the default get error, because it is string and not byte. Used for the function bellow:
self.send('at', frame_id='2', command='SH')default_value = field['default']