macros.newLit now preserves named vs unnamed tuples #14720
Conversation
timotheecour
force-pushed
the
pr_14688_newLit_tuple_takeover
branch
from
35fc8d5 to
8511529
Compare
| ## use -d:nimHasWorkaround14720 to restore behavior prior to PR, forcing | ||
| ## a named tuple even when `arg` is unnamed. | ||
| result = nnkTupleConstr.newTree | ||
| when defined(nimHasWorkaround14720) or isNamedTuple(T): |
There was a problem hiding this comment.
Sometimes, I've thought that it would be nice if the compiler has a generic way to check for the presence of a bug fix (a bit like the generic since mechanism).
Right how, when I encounter an issue, I often leave a TODO comment in the code with a link to the filed issue. If each release of the compiler was storing internally an integer set of all the fixed issues, it would have been possible to write the following code:
when not hasFix(12231):
# some work-around here
else:
{.fatal: "The work-around can be removed now".}There was a problem hiding this comment.
- this would not have helped here, where a bugfix causes some code relying on the bug to fail (see ggplotnim)
- nim already has a mechanism for that using
nimHasFoo(see condsyms.nim), and it's strictly more flexible than an issue number, because it gives you freedom to specify what was fixed; eg if:
bug 1234 contains 2 sub issuesfoo andbar, you can have a nim commit with:nimHasFix1234Foo(ornimHasFixFoo`)
see timotheecour#317 for the detailed proposal
There was a problem hiding this comment.
there is such a library in rust: you can do it as a macro
There was a problem hiding this comment.
I can't find it :( but it checks the issue tracker on compile time e.g. in CI iirc. it's cool
There was a problem hiding this comment.
There was a problem hiding this comment.
no it was much simpler, just something like waitIssue!(..)
https://www.reddit.com/r/rust/comments/gsq5gd/blocked_a_procmacro_that_emits_a_compiler_warning/
There was a problem hiding this comment.
sorry, it seems its blocked!
CI failure unrelated: #14685