Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tables/sharedtables/intsets/etc: fix #13496, #13504, #13505; add lots of tests #13498

Merged
merged 9 commits into from
Feb 26, 2020
Merged

tables/sharedtables/intsets/etc: fix #13496, #13504, #13505; add lots of tests #13498

merged 9 commits into from
Feb 26, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 25, 2020 •
edited
Loading

semi-related

  • added sharedtables.len which seemed like an omission; right now there was no workaround; this helps with testing; if really needed I can remove it from this PR, but at the deteriment of testing-ability (again, this would help here: [superseded] import foo {.all.} #11865 )

@timotheecour timotheecour changed the title fix #13496 handle tombstones [WIP] fix #13496 handle tombstones Feb 25, 2020
@timotheecour timotheecour changed the title [WIP] fix #13496 handle tombstones fix #13496 handle tombstones Feb 25, 2020
@timotheecour timotheecour changed the title fix #13496 handle tombstones tables: fix #13496, #13504; handle tombstones; add tests Feb 26, 2020
@timotheecour timotheecour changed the title tables: fix #13496, #13504; handle tombstones; add tests tables/sharedtables/intsets/etc: fix #13496, #13504, #13505; add lots of tests Feb 26, 2020
@timotheecour timotheecour mentioned this pull request Feb 26, 2020
Closed
@Araq Araq merged commit 42dad3a into nim-lang:devel Feb 26, 2020
@timotheecour timotheecour deleted the pr_fix_13496_tables_values branch February 26, 2020 23:22
narimiran pushed a commit that referenced this pull request Apr 14, 2020
@timotheecour @narimiran
tables/sharedtables/intsets/etc: fix #13496, #13504, #13505; add lots…
2668176 
… of tests (#13498) [backport]

* fix #13496 handle tombstones
* add test
* more tests
* fix #13504; add SharedTable tests
* fix ##13505 intsets.missingOrExcl silently gave wrong results sometimes
* add test for tintsets

(cherry picked from commit 42dad3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timotheecour @Araq