Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more files to the ignore list, hopefully fixes nightlies on windows #13474

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

narimiran
Copy link
Member

Added aliases, ast, astalgo, renderer, trees, types.
Those files were producing errors on Travis on Windows, which led to 700+ or Error: type mismatch: got <>, which in turn led to: The job exceeded the maximum log length, and has been terminated.

(The nightlies on Windows started to fail after #13221)


Other files in a diff are there because I sorted them alphabetically for future generations to have an easier time seeing what's (not) there.

@Araq Araq merged commit 3e8858d into nim-lang:devel Feb 24, 2020
@timotheecour
Copy link
Member

  • +1 for file sorting
  • for the removed files (aliases, ast, astalgo, renderer, trees, types) could a less drastic change have been made, eg when defined(windows): ... ?
    things like https://nim-lang.github.io/Nim/compiler/ast.html in particular are nice to have in docgen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants