Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #9829 #11849

Merged
merged 1 commit into from
Aug 4, 2019
Merged

fix #9829 #11849

merged 1 commit into from
Aug 4, 2019

Conversation

krux02
Copy link
Contributor

@krux02 krux02 commented Jul 29, 2019 •
edited
Loading

fix #9829

@Araq
Copy link
Member

Araq commented Jul 31, 2019

This fix makes no sense to me... the number of iterations that the "jump optimizer" performs is bounded by 10.

@krux02
Copy link
Contributor Author

krux02 commented Jul 31, 2019 •
edited
Loading

It is not the jump optimizer that runs forever, it is the optimized code that causes the problem. The optimizer optimizes the bytecode in a way that opcJmpBack isn't executed anymore. Only opcJmpBack decreses the counter for loop iterations. This means that the optimization changed the semantics of the code.

Nim/compiler/vm.nim

Line 462 in 803406d

dec(c.loopIterations)

@Araq Araq merged commit b73d097 into nim-lang:devel Aug 4, 2019
narimiran pushed a commit that referenced this pull request Aug 12, 2019
@krux02 @narimiran
fixes #9829 (#11849)
0367a1f 
(cherry picked from commit b73d097)
narimiran pushed a commit that referenced this pull request Aug 13, 2019
@krux02 @narimiran
fixes #9829 (#11849)
b9ae306 
(cherry picked from commit b73d097)
narimiran pushed a commit that referenced this pull request Aug 13, 2019
@krux02 @narimiran
fixes #9829 (#11849)
38893a3 
(cherry picked from commit b73d097)
@mratsim mratsim mentioned this pull request Aug 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nim check hangs in macro
2 participants
@krux02 @Araq