Skip to content

add uppercase file extension #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlhxzb
Copy link

@dlhxzb dlhxzb commented May 22, 2025

Bevy 0.16 had became case-sensitive for asset file extensions bevyengine/bevy#17065
So add uppercase STL extension to keep the original behavior of bevy_stl plugin

@dlhxzb dlhxzb force-pushed the add-uppercase-file-extension branch from f947eb6 to e93f97c Compare May 22, 2025 03:22
@nilclass
Copy link
Owner

Thank you for your contribution @dlhxzb.

I'm uncertain if this is a good change to do at this point. Upstream bevy loaders only support lowercase extensions, e.g. https://github.com/bevyengine/bevy/blob/031fa25ff689ffa6019b52324d6b66c4d538dea7/crates/bevy_gltf/src/loader/mod.rs#L227
If possible, I'd like to keep things consistent.

@dlhxzb
Copy link
Author

dlhxzb commented May 22, 2025

Sure, consistent with bevy is good, but I really have logs of STL assets from mujoco menagerie, which can be loaded before 0.16
https://github.com/google-deepmind/mujoco_menagerie/tree/main/unitree_g1/assets

@dlhxzb
Copy link
Author

dlhxzb commented May 29, 2025

@nilclass Otherwise would you please pub StlLoader? Then I can wrap it by my impl of AssetLoader for STL, just like bevy_obj

@nilclass
Copy link
Owner

nilclass commented Jun 3, 2025

@dlhxzb Thanks for sharing your use-case. I understand that this is frustrating.

However, I still think bevy_stl is not the right place to fix this issue.

In my opinion, the previous behavior of bevy was much better, see my comment over there: bevyengine/bevy#17065 (comment)

Otherwise would you please pub StlLoader? Then I can wrap it by my impl of AssetLoader for STL, just like bevy_obj

I've marked it public on main now, please point your dependency there. I'm not sure if it's a good solution long term though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants