Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not possible to configure the BASE_URL for a domain starting with board #154

Open
rafaelchavesfreitas opened this issue Mar 8, 2023 · 1 comment
Labels
backlog bug Something isn't working

Comments

@rafaelchavesfreitas
Copy link

Describe the Bug

It's not possible to configure the BASE_URL for a domain starting with board, becouse https://board.myproject.com contains /board and the function checkBaseUrl of file run.js do this:

 function checkBaseUrl() {

    const baseUrl = process.env.BASE_URL;

    if (baseUrl) {
      if (baseUrl.includes('/board')) {
        return error('env.BASE_URL must point to the root of the webapp');
      }

I think that you can change the code to first check if the baseUrl format is not valid, then check why, somethink like this:

 function checkBaseUrl() {

    const baseUrl = process.env.BASE_URL;

    if (baseUrl && !baseUrl.match(/^https?:\/\/(\.?\w+)+$/)) {
      if (baseUrl.includes('/board')) {
        return error('env.BASE_URL must point to the root of the webapp');
      }

Steps to Reproduce

try to configure the BASE_URL for a domain starting with board

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Board version: [e.g. 1.0.0]
@rafaelchavesfreitas rafaelchavesfreitas added the bug Something isn't working label Mar 8, 2023
@nikku
Copy link
Owner

nikku commented Mar 12, 2023

Good catch. I think the check can be further simplified. It should basically prevent users from setting {TASK_BOARD}/board as the BASE_URL over {TASK_BOARD}.

@nikku nikku added the backlog label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants