Fix variadic trailing comma printer in format preserving printer - option #2 #1126
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-trailing-variadic
branch
from
a3052c8 to
6025314
Compare
TomasVotruba
commented
Oct 27, 2025
TomasVotruba
force-pushed
the
tv-trailing-variadic
branch
from
6025314 to
6f8b234
Compare
samsonasik
reviewed
Nov 21, 2025
| $result .= $this->origTokens->getTokenCode($pos, $endPos + 1, $indentAdjustment); | ||
| $tokenCode = $this->origTokens->getTokenCode($pos, $endPos + 1, $indentAdjustment); | ||
| if ($node instanceof Expr\CallLike && $node->isFirstClassCallable()) { | ||
| $tokenCode = str_replace(',', '', $tokenCode); |
Contributor
There was a problem hiding this comment.
this can use preg_replace() with count arg = 1 to ensure only first , found that removed, see
Suggested change
| $tokenCode = str_replace(',', '', $tokenCode); | |
| $tokenCode = preg_replace('/,/', '', $tokenCode, 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative option to #1125
that does not modify
TokenStream, a value object that should be read-only IMO.To run just this test:
vendor/bin/phpunit test/PhpParser/PrettyPrinterTest.php --filter "args_to"@nikic Let us know whichever you prefer or if you see a better way to fix this bug 👍