Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetting timestep wrong? #11

Closed
YilunZhou opened this issue Sep 27, 2019 · 1 comment
Closed

resetting timestep wrong? #11

YilunZhou opened this issue Sep 27, 2019 · 1 comment

Comments

@YilunZhou
Copy link

The timestep should not be reset on line 182 in PPO.py, because it is used to prevent the episode running too long. Currently it does not affect the performance as the episode length will not exceed max_timesteps, but the logic is wrong. And the same for the continuous case as well.

@nikhilbarhate99
Copy link
Owner

No, timestep is not used to prevent the episode running too long, max_timesteps ensures that. timestep is used to count the number of timesteps from the last update, since we perform update after a fixed number of timesteps (update_timestep). Note that, different episodes can be of different timesteps but the update is performed after a fixed number of timesteps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants