Merge pull request x64dbg#3225 from HayFieldLaps/tabwidget-delete-on-close

mrexodia · web-flow · commit 51e697b726d7 · 2023-10-01T12:49:21.000+02:00
free MHDetachedWindow on reattach
diff --git a/src/gui/Src/Gui/TabWidget.cpp b/src/gui/Src/Gui/TabWidget.cpp
@@ -95,6 +95,9 @@ void MHTabWidget::AttachTab(QWidget* parent)
     // Move the tab back to the previous index
     if(detachedWidget->mPreviousIndex >= 0)
         mTabBar->moveTab(newIndex, detachedWidget->mPreviousIndex);
+
+    //Free MHDetachedWindow
+    delete detachedWidget;
 }
 
 // Convert a tab to an external window

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,9 @@ void MHTabWidget::AttachTab(QWidget* parent)`
`95`	`95`	`// Move the tab back to the previous index`
`96`	`96`	`if(detachedWidget->mPreviousIndex >= 0)`
`97`	`97`	`mTabBar->moveTab(newIndex, detachedWidget->mPreviousIndex);`
	`98`	`+`
	`99`	`+ //Free MHDetachedWindow`
	`100`	`+ delete detachedWidget;`
`98`	`101`	`}`
`99`	`102`
`100`	`103`	`// Convert a tab to an external window`