feat: simplify cache addition in NgHttpCachingInterceptorService and refactor provideNgHttpCaching function

Author: nigrosimone

projects/ng-http-caching/src/lib/ng-http-caching-interceptor.service.ts

@@ -38,7 +38,7 @@ export class NgHttpCachingInterceptorService implements HttpInterceptor {
     const shared = this.sendRequest(req, next).pipe(
       tap(event => {
         if (event instanceof HttpResponse) {
-          this.cacheService.addToCache(req, event.clone());
+          this.cacheService.addToCache(req, event);
         }
       }),
       finalize(() => {

projects/ng-http-caching/src/lib/ng-http-caching-provider.ts

@@ -1,24 +1,23 @@
-import { EnvironmentProviders, makeEnvironmentProviders } from "@angular/core";
+import { EnvironmentProviders, makeEnvironmentProviders, Provider } from "@angular/core";
 import { HTTP_INTERCEPTORS } from "@angular/common/http";
 import { NgHttpCachingInterceptorService } from "./ng-http-caching-interceptor.service";
 import { NG_HTTP_CACHING_CONFIG, NgHttpCachingConfig, NgHttpCachingService } from "./ng-http-caching.service";
 
 export function provideNgHttpCaching(ngHttpCachingConfig?: NgHttpCachingConfig) {
-    const providers: EnvironmentProviders[] = [];
-    if (ngHttpCachingConfig) {
-        providers.push(makeEnvironmentProviders([{
-            provide: NG_HTTP_CACHING_CONFIG,
-            useValue: ngHttpCachingConfig,
-        }]));
-    }
-    providers.push(makeEnvironmentProviders([
+    const providers: Provider[] = [
         NgHttpCachingService,
         {
             provide: HTTP_INTERCEPTORS,
             useClass: NgHttpCachingInterceptorService,
             multi: true,
         },
         NgHttpCachingInterceptorService
-    ]));
-    return providers;
+    ];
+    if (ngHttpCachingConfig) {
+        providers.push({
+            provide: NG_HTTP_CACHING_CONFIG,
+            useValue: ngHttpCachingConfig,
+        });
+    }
+    return makeEnvironmentProviders(providers);
 }