Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version of nodejs in docker.example file in actual master #4357

Closed
maskac opened this issue Feb 13, 2019 · 6 comments
Closed

Incorrect version of nodejs in docker.example file in actual master #4357

maskac opened this issue Feb 13, 2019 · 6 comments
Labels
Milestone

Comments

@maskac
Copy link

maskac commented Feb 13, 2019

In actual docker.example file si nodejs 8.9.1, but 11.1 not functional with it.
Version 11.9 not functional too (message you must upgrade).
Version 10.15.1 see functional.

@PieterGit
Copy link
Contributor

@maskac The docs only allow latest Node 8 or Node 10 LTS. Can you PR the file https://github.com/nightscout/cgm-remote-monitor/blob/dev/Dockerfile.example to use the Node 8.15.0 or Node 10.15.1 version and test to see if that make is work again?

@PieterGit PieterGit added the bug label Feb 16, 2019
@PieterGit PieterGit added this to the 0.11.2 milestone Feb 16, 2019
@maskac
Copy link
Author

maskac commented Feb 16, 2019

Yes, i am allready tests with

"FROM node:10.15.1"

and works fine.

@m-a-v
Copy link
Contributor

m-a-v commented Feb 19, 2019

I'am running Nightscout for several days with "FROM node:10.15.1". I think the best option would be to use the Alpine image. I will do some tests with Alpine and if successful create a PR.

@m-a-v
Copy link
Contributor

m-a-v commented Feb 19, 2019

I have added a PR.

#4392

@PieterGit
Copy link
Contributor

Fixed by merging #4409
Closing PR. Thanks @m-a-v

@m-a-v
Copy link
Contributor

m-a-v commented Feb 25, 2019

Thanks for the merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants