From 6abd6bed2712989f4f389e115f60d719809db569 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Asbj=C3=B8rn=20Aarrestad?= <asbjorn@aarrestad.com>
Date: Fri, 6 Dec 2019 11:27:00 +0100
Subject: [PATCH] Added sanity check for the bridge interval value (#4717)

* Added sanity check for the bridge interval value, setting minimum allowed value to 30 seconds and maximum to 5 minutes. This is to avoid input of very low values which might overload the dexcom servers.

* Added missin ';'

* Fixed typoe in comment

* Added test for default interval (not set in config)

* Set lower limit to 1 second
---
 lib/plugins/bridge.js | 10 +++++++++-
 tests/bridge.test.js  | 41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 1 deletion(-)

diff --git a/lib/plugins/bridge.js b/lib/plugins/bridge.js
index dc47f13aa9b..bf3c67e88da 100644
--- a/lib/plugins/bridge.js
+++ b/lib/plugins/bridge.js
@@ -46,9 +46,17 @@ function options (env) {
     , minutes: env.extendedSettings.bridge.minutes || 1440
   };
 
+  var interval = env.extendedSettings.bridge.interval || 60000 * 2.5; // Default: 2.5 minutes
+
+  if (interval < 1000 || interval > 300000) {
+        // Invalid interval range. Revert to default
+        console.error("Invalid interval set: [" + interval + "ms]. Defaulting to 2.5 minutes.")
+        interval = 60000 * 2.5 // 2.5 minutes
+  }
+
   return {
     login: config
-    , interval: env.extendedSettings.bridge.interval || 60000 * 2.5
+    , interval: interval
     , fetch: fetch_config
     , nightscout: { }
     , maxFailures: env.extendedSettings.bridge.maxFailures || 3
diff --git a/tests/bridge.test.js b/tests/bridge.test.js
index 99c1587fab4..66b69f64c3a 100644
--- a/tests/bridge.test.js
+++ b/tests/bridge.test.js
@@ -10,6 +10,7 @@ describe('bridge', function ( ) {
       bridge: {
         userName: 'nightscout'
         , password: 'wearenotwaiting'
+        , interval: 60000
       }
     }
   };
@@ -27,6 +28,7 @@ describe('bridge', function ( ) {
 
     opts.login.accountName.should.equal('nightscout');
     opts.login.password.should.equal('wearenotwaiting');
+    opts.interval.should.equal(60000);
   });
 
   it('store entries from share', function (done) {
@@ -39,4 +41,43 @@ describe('bridge', function ( ) {
     bridge.bridged(mockEntries)(null);
   });
 
+  it('set too low bridge interval option from env', function () {
+    var tooLowInterval = {
+      extendedSettings: {
+        bridge: { interval: 900 }
+      }
+    };
+
+    var opts = bridge.options(tooLowInterval);
+    should.exist(opts);
+
+    opts.interval.should.equal(150000);
+  });
+
+  it('set too high bridge interval option from env', function () {
+    var tooHighInterval = {
+      extendedSettings: {
+        bridge: { interval: 500000 }
+      }
+    };
+
+    var opts = bridge.options(tooHighInterval);
+    should.exist(opts);
+
+    opts.interval.should.equal(150000);
+  });
+
+  it('set no bridge interval option from env', function () {
+    var noInterval = {
+      extendedSettings: {
+        bridge: { }
+      }
+    };
+
+    var opts = bridge.options(noInterval);
+    should.exist(opts);
+
+    opts.interval.should.equal(150000);
+  });
+
 });