Throw error when recurcive resolving + stack

Removed setter in Resolve func

Author: d.popov

Bridge.Ioc/Abstract/IResolver.cs

@@ -4,6 +4,6 @@ namespace Bridge.Ioc
 {
     public interface IResolver
     {
-        Func<object> Resolve { get; set; }
+        Func<object> Resolve { get; }
     }
 }

Bridge.Ioc/Resolvers/FuncResolver.cs

@@ -4,11 +4,11 @@ namespace Bridge.Ioc
 {
     public class FuncResolver<T> : IResolver
     {
-        public Func<object> Resolve { get; set; }
+        public Func<object> Resolve { get; private set; }
 
         public FuncResolver(Func<T> resolveFunc)
         {
-            this.Resolve = () => resolveFunc();
+            Resolve = () => resolveFunc();
         }
     }
 }

Bridge.Ioc/Resolvers/InstanceResolver.cs

@@ -4,7 +4,7 @@ namespace Bridge.Ioc
 {
     public class InstanceResolver : IResolver
     {
-        public Func<object> Resolve { get; set; }
+        public Func<object> Resolve { get; private set; }
 
         public InstanceResolver(object resolvedObj)
         {

Bridge.Ioc/Resolvers/SingleInstanceResolver.cs

@@ -6,7 +6,7 @@ public class SingleInstanceResolver : IResolver
     {
         private object _singleInstance;
 
-        public Func<object> Resolve { get; set; }
+        public Func<object> Resolve { get; private set; }
 
         public SingleInstanceResolver(IIoc ioc, Type type)
         {

Bridge.Ioc/Resolvers/TransientResolver.cs

@@ -6,30 +6,51 @@ namespace Bridge.Ioc
 {
     public class TransientResolver : IResolver
     {
-        public Func<object> Resolve { get; set; }
+        private static Stack<Type> resolved = new Stack<Type>();
+        private static HashSet<Type> resolving = new HashSet<Type>();
+
+        public Func<object> Resolve { get; private set; }
 
         public TransientResolver(IIoc ioc, Type toresolveType)
         {
-            this.Resolve = () =>
+            Resolve = () =>
             {
                 // get ctor
                 var ctor = toresolveType.GetConstructors().FirstOrDefault();
                 if (ctor == null)
                     throw new Exception($"No ctor found for type {toresolveType.FullName}!");
 
-                // get ctor params
-                var ctorParams = ctor.GetParameters();
-                if (!ctorParams.Any())
-                    return Activator.CreateInstance(toresolveType);
-                else
+                resolved.Push(toresolveType);
+                if (!resolving.Add(toresolveType))
+                {
+                    var message = $"Recursive error in type resolving {toresolveType.FullName}! \n {string.Join(" -> ", resolved.Reverse().Select(a => a.FullName))}";
+                    resolved.Pop();
+                    throw new Exception(message);
+                }
+
+                try
                 {
-                    // recursive resolve
-                    var parameters = new List<object>(ctorParams.Length);
+                    // get ctor params
+                    var ctorParams = ctor.GetParameters();
+                    if (!ctorParams.Any())
+                        return Activator.CreateInstance(toresolveType);
+                    else
+                    {
+                        // recursive resolve
+                        var parameters = new List<object>(ctorParams.Length);
 
-                    foreach (var parameterInfo in ctorParams)
-                        parameters.Add(ioc.Resolve(parameterInfo.ParameterType));
+                        foreach (var parameterInfo in ctorParams)
+                        {
+                            parameters.Add(ioc.Resolve(parameterInfo.ParameterType));
+                        }
 
-                    return ctor.Invoke(parameters.ToArray());
+                        return ctor.Invoke(parameters.ToArray());
+                    }
+                }
+                finally
+                {
+                    resolved.Pop();
+                    resolving.Remove(toresolveType);
                 }
             };
         }