Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elnode error log contains file contents, including binary data #32

Open
db48x opened this issue Aug 13, 2012 · 3 comments
Open

elnode error log contains file contents, including binary data #32

db48x opened this issue Aug 13, 2012 · 3 comments

Comments

@db48x
Copy link

db48x commented Aug 13, 2012

This is a problem when the file contains bytes that form invalid utf-8 sequences, as it goes to an interactive prompt asking the user what encoding to use. It could just default to encoding the file/buffer as raw-text to begin with, or it could run the binary data through some kind of encoding first. For now I'm just turning off the logging by setting elnode--do-error-logging to nil.

Example:
20120813101139: elnode-http-send-string elnode-webserver-proc 10.0.38.28:14778 [[GIF87aT^@t^@\366^?^@\377\377\377^@^X\214\354]]

@nicferrier
Copy link
Owner

Thanks for the report, I will get a fix together unless you want to?

@db48x
Copy link
Author

db48x commented Aug 15, 2012

I just tried running it through url-hexify-string. This works, of course, but it looks silly because every space character becomes a %20.

@nicferrier
Copy link
Owner

One thing: the latest Elnode (0.9.9) does not log send-strings by default. So you could check you're using that. I'm not even sure logging send-strings ever is a good idea, I did it for debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants