Skip to content

Conversation

@epage
Copy link
Contributor

@epage epage commented Aug 7, 2017

This is only relevant to SignalsWaveform and will be re-added by #161.

Fixes #121.

BREAKING CHANGE: session.signals no longer has a resamp_rate property.
This never worked anyways so it shouldn't impact anyone.

  • This contribution adheres to CONTRIBUTING.md.
  • New tests have been created for any new features or regression tests for bugfixes.
  • tox successfully runs, including unit tests and style checks (see CONTRIBUTING.md).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 64.185% when pulling a7b8f65 on epage:resamp into 5590c92 on ni:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 64.185% when pulling a7b8f65 on epage:resamp into 5590c92 on ni:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 64.185% when pulling a7b8f65 on epage:resamp into 5590c92 on ni:master.

@coveralls
Copy link

coveralls commented Aug 7, 2017

Coverage Status

Coverage increased (+0.009%) to 64.185% when pulling a7b8f65 on epage:resamp into 5590c92 on ni:master.

This is only relevant to SignalsWaveform and will be re-added by ni#161.

Fixes ni#121.

BREAKING CHANGE: `session.signals` no longer has a `resamp_rate` property.
This never worked anyways so it shouldn't impact anyone.
@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage increased (+0.003%) to 64.179% when pulling b5b0197 on epage:resamp into 5590c92 on ni:master.

@epage epage merged commit 2b0b3bd into ni:master Aug 8, 2017
@epage epage deleted the resamp branch August 8, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move get and set resamp_rate to the relevant Signal classes

2 participants