Skip to content

feat(API): Support read/write signal waveforms #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(API): Support read/write signal waveforms #161

wants to merge 4 commits into from

Conversation

@epage
Copy link
Contributor

@epage epage commented Jul 31, 2017

Fixes #121, #40

  • This contribution adheres to CONTRIBUTING.md.
  • New tests have been created for any new features or regression tests for bugfixes.
  • tox successfully runs, including unit tests and style checks (see CONTRIBUTING.md).

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling d908967 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling 8449ecc on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling 70ca347 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling f652161 on epage:signal into c421c95 on ni:master.

3 similar comments
@coveralls
Copy link

coveralls commented Jul 31, 2017

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling f652161 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling f652161 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling f652161 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling e568f2d on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling 90c1357 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.97% when pulling 7c4eb99 on epage:signal into c421c95 on ni:master.

@coveralls
Copy link

coveralls commented Aug 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 65.845% when pulling d7220c4 on epage:signal into e1bf22e on ni:master.

epage added 4 commits August 3, 2017 17:02
@epage
feat(API) Suppot read/write signal waveforms
bc70e58
@epage
fix(API): Limit resamp_rate to only relevant modes.
a708f25 
Not really counting this as a breaking change because the property
would error in the other modes anyways.

Fixes ni#121
@epage
docs: Create Signal Waveform example
24b9fbe 
Fixes ni#40
@epage
tests: Verify waveform sessions
e0c4c02 
The number of samples needs to be kept down to avoid overflowing the
buffer.
@coveralls
Copy link

coveralls commented Aug 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 64.823% when pulling e0c4c02 on epage:signal into f87765f on ni:master.

epage added a commit to epage/nixnet-python that referenced this pull request Aug 7, 2017
@epage
fix(API): Remove irrelevant resamp_rate property
a7b8f65 
This is only relevant to SignalsWaveform and will be re-added by ni#161.

Fixes ni#121.

BREAKING CHANGE: `session.signals` no longer has a `resamp_rate` property.
This never worked anyways so it shouldn't impact anyone.
@epage epage mentioned this pull request Aug 7, 2017
Merged
3 tasks
epage added a commit to epage/nixnet-python that referenced this pull request Aug 8, 2017
@epage
fix(API): Remove irrelevant resamp_rate property
b5b0197 
This is only relevant to SignalsWaveform and will be re-added by ni#161.

Fixes ni#121.

BREAKING CHANGE: `session.signals` no longer has a `resamp_rate` property.
This never worked anyways so it shouldn't impact anyone.
@d-bohls d-bohls assigned d-bohls and unassigned bcornish Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move get and set resamp_rate to the relevant Signal classes

4 participants

@epage @coveralls @bcornish @d-bohls