Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language configuration is confusing #126

Open
TrevorKarjanis opened this issue Jul 18, 2023 · 1 comment
Open

Language configuration is confusing #126

TrevorKarjanis opened this issue Jul 18, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@TrevorKarjanis
Copy link
Collaborator

TrevorKarjanis commented Jul 18, 2023

The following feedback was given for configuring a new Angular application with linting.

I wasn't sure which linters to configure. Are we meant to configure linters for JavaScript, Typescript, and Angular, or is just Angular sufficient? I think I eventually figured out that I need to configure Angular and JavaScript (as the Angular config talks about removing the TypeScript config, but I got hung up on this for a while). I think we could clarify this step.

Fix

  1. Clarify in the docs that the TS and Angular configurations include the TypeScript and JavaScript configs.
  2. Add an override for *.js to the docs for the Angular configuration
  3. Update the docs to mention the need to add something like this to angular.json (after verifying that it's necessary for our current version of Angular)
         "lintFilePatterns": [
              "src/**/*.ts",
              "src/**/*.html",
              "acceptance-tests/**/*.ts",
              "acceptance-tests/**/*.js"
            ]
@jattasNI
Copy link
Collaborator

I split off config changes to #127 so now this should be a doc change that's relatively easy to knock out.

@jattasNI jattasNI added the good first issue Good for newcomers label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants