-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links #324
Comments
I think our page on links needs expanding to address linked text within sentences, especially to clarify which words should be linked text, and which shouldn't. Example I've just seen on Moving to a new home: housing options GOV.UK: contact your local council to find out about sheltered housing schemes in your area To my mind, the words "to find out about sheltered housing schemes in your area" would not be part of the linked text, as this is not the action you take when you click the link, it's a secondary action. However, the entire sentence is linked text. Also, in a preceding paragraph, we have: This is an example of two different approaches to linked text within the same content. I think we need more examples and "rules" on our guidance page about:
|
Thanks @thelittlelostgirl79, I'll follow this up. We have a similar task in our backlog: #182 |
A minor thing but could we update the link for "Read more about opening new windows and tabs on W3C" to point to the latest WCAG 2.1 page (https://www.w3.org/WAI/WCAG21/Techniques/general/G200) rather than the older WCAG 2.0 version (https://www.w3.org/TR/WCAG20-TECHS/G200.html). |
That makes sense, @mcheung-nhs. I'll put a task in the team backlog for this. |
SuggestionI'd like to make a suggestion to this part of the page, about when it's ok to open a link in a new window or tab:
I think it would be good to follow the guidance in the GOV Design System (https://design-system.service.gov.uk/styles/typography/#opening-links-in-a-new-tab) and add another exception (or add further clarity to the first point) which says...
ReasoningWe're having a discussion internally around the 'footer' component (https://service-manual.nhs.uk/design-system/components/footer) and whether these links should open in the same window, or a new one. Given a number of our services are transactional by nature, I believe they should open in a new window to avoid users potentially losing any information they may have entered into a form. We would aim to do this (and to meet the WCAG 3.2.5 criterion) by doing something like...
|
@StephenHill-NHSBSA, this article could be of use https://javascript.plainenglish.io/how-to-make-an-accessible-opens-in-a-new-tab-icon-in-12-lines-of-react-e99ce5f25b5d Personally, I'm in favour of new tab icons with accessible text beneath. But I'm not sure whether GDS needs verbose new tab text for sighted users, or if the icon would suffice. The icon is fairly standard across the web, so it depends on whether it's a core part of the service. In your example above with footer items, it would make sense to preface it with text, rather than having an icon or new tab text per item. |
I'm a bit wary of icons to be honest. There's the well known phrase that 'metaphors change with time' so what might be well understood at one point, might be totally misunderstood the next. Take the floppy disk icon for example. Again, I like the advice that the GOV Design System say:
|
GOV.UK removed their external link icon a few years ago. There's a blog post about it: https://designnotes.blog.gov.uk/2016/11/28/removing-the-external-link-icon-from-gov-uk/. We've also got some info about external links in this GitHub issue: Links - external and internal Our current guidance about when to open a new tab is based on W3C guidance: G200: Opening new windows and tabs from a link only when necessary but I think we could specify the additional exception. Let's see if we get further comments, but I'll mark this as an issue we could potentially discuss and approve at the next Content Style Council meeting (probably in September). |
Our team wondered if we needed to include the file size of the PDF if we link to the HTML page to download it. The link guidance states:
Our decision was to include the file size in the link. This is because:
|
A few things it would be good to expand the guidance on: I was looking for guidance on external links. In the GOV.UK design system, this guidance exists in the styles>links section. In the NHS design system it's in the content section. I think it would be good to mention external links from the styles section and then link to the content section. For the content section I think we could also mention:
|
Re above: GOV.UK advises: "The following links open in a new tab". (https://design-system.service.gov.uk/styles/links/#external-links) |
Use this issue to discuss the guidance on links in the service manual.
Related issues
The text was updated successfully, but these errors were encountered: