Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeGridRows[endRowIndex] is undefined error in week view when mouse drag on other column #1239

Closed
henryfool91 opened this issue Aug 7, 2022 · 5 comments
Labels
2.0 New versions Bug

Comments

@henryfool91
Copy link

Hey guys! Thanks again for the great package!
I suppose i found a bug :)

Version

2.1.1

Current Behavior

Start select time in week view, drag to other column. After that calendar crashes
TEST

Also, is there a way to completely turn off selections? I know about "isReadOnly" option, but i need to modify events thought dragging, so isReadOnly is not the way

Thanks in advance!

@adhrinae adhrinae added Bug 2.0 New versions labels Aug 7, 2022
@adhrinae
Copy link
Contributor

adhrinae commented Aug 7, 2022

It might be related to #1238.

@adhrinae
Copy link
Contributor

adhrinae commented Aug 7, 2022

@henryfool91 You can disable selection via the gridSelection option.

https://github.com/nhn/tui.calendar/blob/main/docs/en/apis/options.md#gridselection

@henryfool91
Copy link
Author

henryfool91 commented Aug 7, 2022

@henryfool91 You can disable selection via the gridSelection option.

https://github.com/nhn/tui.calendar/blob/main/docs/en/apis/options.md#gridselection

I did that, It works on click and double click, but click and drug still select

@adhrinae
Copy link
Contributor

adhrinae commented Aug 8, 2022

@henryfool91
Then please use the previous version(2.1.0 or 2.0.5) until the bug is fixed.
This bug appears when you set the week.hourStart or the week.hourEnd option. Every version from v2 is affected.

I'll try to fix it ASAP.


Furthermore, I didn't consider whether we should offer the option of completely disabling grid selection yet.

@henryfool91
Copy link
Author

henryfool91 commented Aug 9, 2022

2.1.2 fixes the issue, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 New versions Bug
Projects
None yet
Development

No branches or pull requests

2 participants