Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-3570 - Insert + delete collection item issue using versioned parent #1322

Open
nhibernate-bot opened this issue Oct 13, 2017 · 0 comments

Comments

@nhibernate-bot
Copy link
Collaborator

Roger created an issue — 12th November 2013, 11:27:10:

tran start
session.save(parentWithChildren)
parentWithChildren.RemoveChild()
parentWithChildren.AddChild()
tran commit

The child(ren) that is removed after session.save will still be saved when committing transaction. -> incorrect.
Also, the bug is worse if collection is indexed. Then the data in database will be corrupt (incorrect index) and can't be read.

This only occurs if parent entity is versioned.

I'll create a pull request soon.


Roger added a comment — 12th November 2013, 12:06:41:

pull request with failing tests is here
#236


Oskar Berggren added a comment — 10th February 2014, 0:36:50:

Is this a regression?


Alexander Zaytsev added a comment — 10th February 2014, 0:43:57:

I did not check, but I don't think that it is regression.


Roger added a comment — 10th February 2014, 8:41:06:

@oskar,
I found it on 4.0 alpha, but my guess it's not a regression. Not sure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants