Remove the deprecated domain annotation on Load balancer services in … #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…favor of the url annotation
github-actions
bot
added
area/controller
jonstacks
reviewed
Dec 5, 2025
| }) | ||
| }) | ||
|
|
||
| When("service has domain annotation", func() { |
Collaborator
There was a problem hiding this comment.
I think you can remove this entire block, we should have a test up above for the TLS url annotation if I'm not mistaken.
github-actions
bot
added
size/L
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 48.98% 48.91% -0.07%
==========================================
Files 95 95
Lines 10594 10591 -3
==========================================
- Hits 5189 5181 -8
- Misses 5046 5047 +1
- Partials 359 363 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonstacks
reviewed
Dec 5, 2025
| return err | ||
| default: // computedURL not present, fallback to the domain annotation | ||
| domain, err := parser.GetStringAnnotation("domain", svc) | ||
| default: // computedURL not present, fallback to parsing the URL annotation |
Collaborator
There was a problem hiding this comment.
I think there is a tricky case here with removing domain.
- When we were using the
domainannotation it implied that it was a TLS service. This also implied that the domain should be reserved and that we'd have a domain status to get. The core piece is that we were only looking at domain which would only be for TLS services. - The reason we introduced the internal
computed-urlannotation is that we had to handle thetcp://case, where it means: "Please give me a random TCP url and keep using it". We don't own the spec Service and we don't currently have aTCPAddrCRD (maybe we should now), so we needed a place to store the reserved addr. - Now that domain annotation is removed, if we don't have the
computed-urlannotation (the default case here), it looks like we are still going to try to parsetcp://instead and use that to update the status.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…favor of the url annotation
What
This has been deprecated for a while in favor of the k8s.ngrok.com/url annotation. We should remove this
How
Simply removes the old code paths and updates some comments and documentation.
Breaking Changes
Yes, this deletes the
k8s.ngrok.com/domainannotation support from the LoadBalancer Service. Its been deprecated for some time now in favor ofk8s.ngrok.com/url