Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Events for Resources #399

Open
jonstacks opened this issue Jul 9, 2024 · 0 comments
Open

Better Events for Resources #399

jonstacks opened this issue Jul 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request priority/medium

Comments

@jonstacks
Copy link
Collaborator

Description

For some changes to resources that the ingress-controller/operator watches(ngrok CRs, ingress, service, gateway, etc), we don't always create events that shows what the controller is doing.

For example, when running kubectl scale deployment ngrok-ascii --replicas=<N>, the kubernetes deployment controller will log events for scaling the deployment as an example:
image
The replicaset controller will also create events as well as part of this scaling action:
image

It also very common for pod issues to be reported as events such as readiness or liveness probes failing. This helps users debug issues without having to go diving through all of the controller logs.

For instance, when creating an Ingress resource with ingressClassName: ngrok, if I describe it with kubectl describe ingress my-ingress, there won't be any events.

Use Case

The use case for this is to make it easier to see what is happening inside of the controller without having to dive into the logs for simple issues. For resources that create ngrok CRs(service, ingress, gateway), we should create events that bubble up any issues or state change in the particular resource or the CRs to make it easier for end users.

Related issues

No response

@jonstacks jonstacks added enhancement New feature or request needs-triage Issues that need triage labels Jul 9, 2024
@deroine deroine added priority/medium and removed needs-triage Issues that need triage labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium
Projects
None yet
Development

No branches or pull requests

3 participants