trackRequestResult & angular guard not returning cached data

[UnleashSpirit]

Which @ngneat/elf-* package(s) are the source of the bug?

requests-status, requests-cache

Is this a regression?

No

Description

Hi,
We just begin to use elf (instead of akita) for a simple need of cache (store will come later).

In our case we have a route behind a canActivate Guard.
If we use trackRequestResult with cacheResponseData: true, the next call to the request return an EMPTY Observable.
This appears to be because the query never trigger the 'complete' state so we got nothing from this code :

if (result.fetchStatus === 'fetching' && preventConcurrentRequest && !options?.skipCache && !stale) {
  return getRequestResult(key).pipe(
    filter((requestResult) => requestResult.fetchStatus === 'idle'),
    switchMap((requestResult) => {
      if (requestResult.isError) {
        return throwError(() => requestResult.error)
      }
      if (requestResult.isSuccess) {
        return of(requestResult.responseData)
      }
      return EMPTY
    }),
    take(1)
  )
}
)

We go in cause if return true but got nothing cause filter((requestResult) => requestResult.fetchStatus === 'idle' emit nothing.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No expetion, no error, just nothing

Please provide the environment you discovered this bug in

A service API with the request tracked

// todos.service.ts

getTodos(): Observable<Todos> {
  return this.httpClient.request<Todos>(...).pipe(
    trackRequestResult(['todos'], { cacheResponseData: true })
  );
}

A component behind a route with canActivate guard

const routes: Routes = [
  {
    path: '/todos',
    component: 'TodosComponent',
    canActivate: ['TodosGuard']
  }
]

In this guard use the service to call the API request (the switch hide business logic, simplified here)

canActivate(_route: ActivatedRouteSnapshot, _state: RouterStateSnapshot): Observable<boolean> {
  return this.todosService.getTodos().pipe(switchMap(() => of(true)));
}

In the component, call the same request

ngOnInit(): void {
  this.todosService.getTodos().subscribe() // or | async in html;
}

The component never get the cached data (done by the guard)

Anything else?

We override the request-result.ts fro mthe lib and it seems that the query from the guard never goes through the complete here :

return source.pipe(
  tap({
    error(error) {
      console.log('error ' + key)
    },
    next(data) {
      console.log('next ' + key)
    },
    complete() {
      console.log('complete ' + key)
    },
    finalize() {
      console.log('finalize ' + key)
    }
  })
)

We have the next and the finalize (we had it) but never the complete.

If we subscribe in the guard instead of returning it, it seems to work.

canActivate(_route: ActivatedRouteSnapshot, _state: RouterStateSnapshot): Observable<boolean> {
  this.todosService.getTodos().pipe(switchMap(() => of(true))).sbuscribe();
  return of(true);
}

No solution found till now for us.

Do you want to create a pull request?

No

[NetanelBasal]

But EMPTY completes the observable - https://github.com/ReactiveX/rxjs/blob/master/packages/rxjs/src/internal/observable/empty.ts#L65

[NetanelBasal]

I guess the issue is that it doesn't return a boolean