Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding a component does not hide its picking selections or its measurements #588

Open
Treppenhouse opened this issue Oct 18, 2018 · 1 comment

Comments

@Treppenhouse
Copy link

Treppenhouse commented Oct 18, 2018

The problem occurs when making a measurement or picking/selecting elements and the green bubbles are displayed. When I then hide the component via the eye button, those bubbles are still there, along with the measurements.

Before hiding:
ngl1

After hiding:
ngl2

Expected behaviour:
I would expect that selection bubbles would be hidden together with the component. Regarding the measurements I can see that it might make sense to keep them displayed, but I don't see the point of keeping the selection bubbles.

Suggestion:
In the structure-components.ts one could override the setVisibility() method like this:

  setVisibility (value: boolean) {
    super.setVisibility(value);

    this.measureRepresentations.setVisibility(value);
    this.spacefillRepresentation.setVisibility(value);

    return this;
  }

If you agree, then I can create a merge request for this.

@arose
Copy link
Collaborator

arose commented Jan 7, 2019

Sounds good,please do a PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants