Skip to content

fix: sections with same name expand together #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

JTorreG
Copy link
Collaborator

@JTorreG JTorreG commented May 11, 2023

Proposed changes

Changes the logic that generates the collapsible sections ID and HREF in the navigation bar to include the section and subsection in the string. This fixes several sections with the same name expanding/collapsing together.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@JTorreG JTorreG requested a review from travisamartin May 11, 2023 16:57
@JTorreG JTorreG self-assigned this May 11, 2023
@JTorreG JTorreG merged commit 80697b8 into main May 11, 2023
@JTorreG JTorreG deleted the nav-fix-redux branch May 11, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants