Skip to content

feat: Fix navigation bar issues #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

feat: Fix navigation bar issues #6

merged 1 commit into from
May 9, 2023

Conversation

JTorreG
Copy link
Collaborator

@JTorreG JTorreG commented May 8, 2023

Proposed changes

  • Add a 4th level to the navigation bar (fixes sections that stopped working after being pushed 1 level deeper)
  • When loading one product's landing page, the Level 1 sections for the product expand automatically

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@JTorreG JTorreG requested a review from jputrino May 8, 2023 19:52
@JTorreG JTorreG self-assigned this May 8, 2023
@JTorreG JTorreG merged commit 518ab80 into main May 9, 2023
@JTorreG JTorreG deleted the nav-fix branch May 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@jputrino jputrino Awaiting requested review from jputrino

Assignees

@JTorreG JTorreG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JTorreG @ADubhlaoich