Skip to content

Coveo z-index + make sticky #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Coveo z-index + make sticky #189

merged 1 commit into from
Mar 27, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Mar 25, 2025

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/398 and https://github.com/nginxinc/docs-platform/issues/403 and https://github.com/nginxinc/docs-platform/issues/410

Before (z-index issue):
Screenshot 2025-03-25 at 11 39 04 AM

After (z-index issue):
Screenshot 2025-03-25 at 11 38 24 AM

Before (sticky):
Screenshot 2025-03-25 at 11 39 53 AM

After (sticky):
Screenshot 2025-03-25 at 11 41 01 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Mar 25, 2025
@lamATnginx lamATnginx self-assigned this Mar 25, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 25, 2025 18:38
@nginx-jack
Copy link
Collaborator

z-index, sticky working great now 👍 .
There's a small issue with the searchbox change the sidebar position (which I think was masked by the breadcrumb having some initial height when they shared a row).
On a fast connection it's a flicker on page load, but on anything slow the sidebar very obviously shifts down when the searchbox loads.
Maybe a min-height on the div around the searchbox, that matches the known height of the searchbox? 🤔
At some point, would could implement a skeleton loading thing.. but that might be overkill!

Screenshot 2025-03-26 at 11 43 37 Screenshot 2025-03-26 at 11 43 49

@lamATnginx
Copy link
Collaborator Author

Thanks for the feedback. Addressing it soon.

@lamATnginx lamATnginx force-pushed the fix/coveo-position branch 5 times, most recently from ceef614 to 055b374 Compare March 26, 2025 19:33
@lamATnginx
Copy link
Collaborator Author

Ready for review again.

Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The search box still flashes on page change, but things aren't shifting around anymore.
I'll make another bug for the searchbox flashes.. we might need to pre-render that search box, before coveo loads in or something. For another ticket anyway :) .

@lamATnginx lamATnginx merged commit d52c2ab into main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants