Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action return type error message #828

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Fix action return type error message #828

merged 1 commit into from
Jan 22, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Bug

Error message does not accurately describe validation requirements

Proposed changes

Made error message reflect validation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Jan 20, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jan 20, 2020
pleshakov
pleshakov approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit 49b8ece into master Jan 22, 2020
@Dean-Coakley Dean-Coakley deleted the fix-action-return-errmsg branch January 22, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox