Add exact matches and regex support to location paths in VS/VSR #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellet
reviewed
Nov 18, 2019
Dean-Coakley
approved these changes
Nov 18, 2019
pleshakov
approved these changes
Nov 20, 2019
Rulox
force-pushed
the
location-regex
branch
from
ae04ab3
to
f203274
Compare
pleshakov
changed the title
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the ability to use exact matches (
=) and case sensitive/insensitive regular expressions (~,~*) in VS/VSR route paths.@tellet Please have a look at the Test methods and let me know if more edge cases can be added to improve validation, thank you.