Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS redirect support in Virtualserver #748

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Support redirects in the Virtualserver.

Breaking changes

The following configmap entires no longer have any effect on generated configs when VS/VSRs are enabled:

  • redirect-to-https
  • ssl-redirect

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added enhancement Pull requests for new features/feature enhancements change Pull requests that introduce a change labels Oct 31, 2019
@Dean-Coakley Dean-Coakley self-assigned this Oct 31, 2019
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley thanks. please update the supported status codes. my bad that didn't catch that earlier.

pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley merged commit d9a5e1a into master Nov 1, 2019
@Dean-Coakley Dean-Coakley deleted the support-tls-redirect branch November 1, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants