Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue of ingress.class annotation handling #74

Merged
merged 2 commits into from
Nov 22, 2016
Merged

Fixed the issue of ingress.class annotation handling #74

merged 2 commits into from
Nov 22, 2016

Conversation

tangle329
Copy link
Contributor

Signed-off-by: Tang Le tangle3@wanda.cn

Signed-off-by: Tang Le <tangle3@wanda.cn>
@pleshakov
Copy link
Contributor

@tangle329
Thanks!

The bug appears if we do the following:

  1. Create an Ingress resource that is not supposed to be handled by NGINX. For example, with the annotation kubernetes.io/ingress.class: "gce"
  2. Change the Configmap with the NGINX configuration or Change one of the services referenced in the Ingress
  3. Ingress resources gets handled by NGINX --> Bug

The bug appears if the endpoints of one of the services change, for example, if we scale the corresponding replication controller. Could you fix that too?

@pleshakov
Copy link
Contributor

@tangle329 thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants