Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting log level in helm chart #600

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Support setting log level in helm chart #600

merged 1 commit into from
Jun 24, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley
Add log level support to helm chart
a6a9f66 
* Fix typo in cmd/nginx-ingress/main.go cresting->creating
@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jun 24, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jun 24, 2019
Rulox
Rulox approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pleshakov
pleshakov approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit befa613 into master Jun 24, 2019
@Dean-Coakley Dean-Coakley deleted the feature/helm-log-level branch June 24, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox