Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom annotations for IC pods in Helm #553

Merged
merged 1 commit into from
May 2, 2019
Merged

Allow custom annotations for IC pods in Helm #553

merged 1 commit into from
May 2, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented May 1, 2019 •
edited by pleshakov
Loading

Proposed changes

This PR introduces the possibility of adding extra annotations to the Ingress Controller pods via Helm Chart.
Fixes #551

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox requested a review from pleshakov May 1, 2019 10:10
@Rulox Rulox self-assigned this May 1, 2019
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label May 1, 2019
pleshakov
pleshakov approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 5f3c27a into master May 2, 2019
@Rulox Rulox deleted the helm-pod-specs branch May 2, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Rulox Rulox

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding pod spec annotations to nginx plus daemonset/deployment chart template
2 participants
@Rulox @pleshakov