Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for active health checks for Plus #286

Merged
merged 2 commits into from
May 23, 2018
Merged

Add support for active health checks for Plus #286

merged 2 commits into from
May 23, 2018

Conversation

isaachawley
Copy link
Contributor

@isaachawley isaachawley commented May 22, 2018

NGINX Plus supports active health checks.

To use, set the annotation nginx.com/health-checks: "true". The Ingress Controller will pull health check (Readiness Probe) information from the Kubernetes API and configure matching active health checks in NGINX Plus.

The bug appeared when a service was referenced multiple times from the same host rule of an Ingress resource via different ports. Only one upstream was generated, instead of multiple upstreams, with one upstream per port.
NGINX Plus supports active health checks.

To use, set the annotation `nginx.com/health-checks: "true"`. The Ingress Controller will pull health check (Readiness Probe) information from the Kubernetes API and configure matching active health checks in NGINX Plus.
@pleshakov pleshakov merged commit 9394492 into nginxinc:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants