main v1.7.1 [unitd --control 127.0.0.1:8300]: [alert] 28169#28169 process 28858 exited on signal 11

[maksitop]

Hi!
messages.log
Feb 12 14:05:14 srvdb004 kernel: unitd[28863]: segfault at b8 ip 00007f9a06680c9e sp 00007f9a01bc8b00 error 4 in unitd[7f9a0665d000+49000]
Feb 12 14:05:14 srvdb004 unit: main v1.7.1 [unitd --control 127.0.0.1:8300]: [alert] 28169#28169 process 28858 exited on signal 11
unit.log
2019/02/12 14:05:14.791 [warn] 28859#28859 [unit] failed to send shm to 28858: Broken pipe (32)
2019/02/12 14:05:14.791 [warn] 28859#28859 [unit] port_send(8, 16) failed: Broken pipe (32)
2019/02/12 14:05:14.791 [alert] 28859#28859 [unit] #4: last message send failed: Broken pipe (32)

Help!

[VBart]

Unfortunately, these messages have no information about the problem.

Could you provide your configuration, describe your setup and conditions when you experienced this crash? Also, enabling debug logging will help: http://unit.nginx.org/troubleshooting/#debug-log

[maksitop]

#unitd --control 127.0.0.1:8300
#curl 127.0.0.1:8300
{
"certificates": {},
"config": {
"listeners": {
"*:8301": {
"application": "sar"
}
},

            "applications": {
                    "sar": {
                            "type": "php",
                            "processes": 2,
                            "root": "/var/www/html/",
                            "user": "nobody",
                            "group": "nobody",
                            "index": "index.php",
                            "limits": {
                                    "timeout": 10
                            }
                    }
            }
    }

}
#wget http://127.0.0.1/sar/index.htm
--2019-02-12 16:33:06-- http://127.0.0.1/sar/index.htm
Connecting to 127.0.0.1:80... connected.
HTTP request sent, awaiting response... 408 Request Timeout
2019-02-12 16:33:06 ERROR 408: Request Timeout.

Feb 12 16:31:22 srvdb004 unit: router: [alert] 29261#29265 *9 writev(-1, 2) failed (9: Bad file descriptor)
Feb 12 16:31:22 srvdb004 kernel: unitd[29265]: segfault at b8 ip 00007f9a06680c9e sp 00007f9a025c9b00 error 4 in unitd[7f9a0665d000+49000]
Feb 12 16:31:22 srvdb004 kernel: unitd[29262]: segfault at ffffffffffffffe1 ip 00007f9a037c7868 sp 00007fffcde99fb0 error 4 in php.unit.so[7f9a037c3000+a000]
Feb 12 16:31:22 srvdb004 unit: main v1.7.1 [unitd --control 127.0.0.1:8300]: [alert] 28169#28169 process 29262 exited on signal 11
Feb 12 16:31:22 srvdb004 unit: main v1.7.1 [unitd --control 127.0.0.1:8300]: [alert] 28169#28169 process 29261 exited on signal 11

2019/02/12 16:31:22 [info] 31508#31508 OpenSSL 1.0.1e-fips 11 Feb 2013, 1000105f
2019/02/12 16:31:22 [info] 31509#31509 "sar" application started
2019/02/12 16:31:22 [info] 31509#31509 (non ABS_MODE) php root: "/var/www/html"
2019/02/12 16:31:22 [info] 31510#31510 "sar" application started
2019/02/12 16:31:22 [info] 31510#31510 (non ABS_MODE) php root: "/var/www/html"

Started after update Feb 12 13:45:29 srvdb004 yum[27540]: Updated: unit-1.7.1-1.el6.ngx.x86_64
Feb 12 13:45:30 srvdb004 yum[27540]: Updated: unit-python-1.7.1-1.el6.ngx.x86_64
Feb 12 13:45:30 srvdb004 yum[27540]: Updated: unit-perl-1.7.1-1.el6.ngx.x86_64
Feb 12 13:45:30 srvdb004 yum[27540]: Updated: unit-go-1.7.1-1.el6.ngx.x86_64
Feb 12 13:45:30 srvdb004 yum[27540]: Updated: unit-php-1.7.1-1.el6.ngx.x86_64

before there was a problem
Feb 12 13:41:18 srvdb004 unit: router: [alert] 32673#798 *153 writev(-1, 2) failed (9: Bad file descriptor)
Feb 12 13:41:18 srvdb004 kernel: unitd[798]: segfault at b8 ip 00007f539b060c9e sp 00007f5395ba7b00 error 4 in unitd[7f539b03d000+49000]
Feb 12 13:41:18 srvdb004 unit: main v1.7 [unitd --control 127.0.0.1:8300]: [alert] 32670#32670 process 32673 exited on signal 11
Feb 12 13:41:18 srvdb004 unit: "example_python" application: [alert] 27399#27399 Python failed to import module "wsgi"
Feb 12 13:41:18 srvdb004 abrt: detected unhandled Python exception in 'unit'
Feb 12 13:41:18 srvdb004 unit: router: [alert] 27396#27396 failed to apply new conf
Feb 12 13:41:18 srvdb004 unit: controller: [alert] 32672#32672 failed to apply previous configuration
Feb 12 13:43:10 srvdb004 mple_python" application: [alert] 27488#27488 Python failed to import module "wsgi"
Feb 12 13:43:10 srvdb004 abrt: detected unhandled Python exception in 'unit'
Feb 12 13:43:10 srvdb004 er: [alert] 27485#27485 failed to apply new conf
Feb 12 13:43:10 srvdb004 roller: [alert] 27484#27484 failed to apply previous configuration

the configuration did not change month and worked

[maksitop]

debug
unit.log

[VBart]

@maksitop Thank you very much for the report. We are working on the fix.

[VBart]

@maksitop Could you show unitd --version as well?

[VBart]

@maksitop please try the following patch:

diff -r 6d72c218a055 -r db5b1fa66046 src/nxt_timer.c
--- a/src/nxt_timer.c   Mon Feb 11 15:42:16 2019 +0300
+++ b/src/nxt_timer.c   Tue Feb 12 22:12:09 2019 +0300
@@ -159,9 +159,9 @@ nxt_timer_change(nxt_event_engine_t *eng
 static void
 nxt_timer_changes_commit(nxt_event_engine_t *engine)
 {
-    nxt_timer_t         *timer, **add, **add_end;
+    nxt_timer_t         *timer;
     nxt_timers_t        *timers;
-    nxt_timer_change_t  *ch, *end;
+    nxt_timer_change_t  *ch, *end, *add, *add_end;
 
     timers = &engine->timers;
 
@@ -170,7 +170,7 @@ nxt_timer_changes_commit(nxt_event_engin
     ch = timers->changes;
     end = ch + timers->nchanges;
 
-    add = (nxt_timer_t **) ch;
+    add = ch;
     add_end = add;
 
     while (ch < end) {
@@ -185,7 +185,7 @@ nxt_timer_changes_commit(nxt_event_engin
 
             timer->time = ch->time;
 
-            *add_end++ = timer;
+            *add_end++ = *ch;
 
             if (!nxt_timer_is_in_tree(timer)) {
                 break;
@@ -209,7 +209,7 @@ nxt_timer_changes_commit(nxt_event_engin
     }
 
     while (add < add_end) {
-        timer = *add;
+        timer = add->timer;
 
         nxt_debug(timer->task, "timer rbtree insert: %M±%d",
                   timer->time, timer->bias);

[maksitop]

unitd --version

unitd --version
unit version: 1.7.1
configured as ./configure --prefix=/usr --state=/var/lib/unit --control=unix:/var/run/control.unit.sock --pid=/var/run/unit.pid --log=/var/log/unit.log --tests --openssl --modules=/usr/lib64/unit/modules --libdir=/usr/lib64 --cc-opt='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC' --ld-opt='-Wl,-z,relro -Wl,-z,now -pie'

Name : unit Relocations: (not relocatable)
Version : 1.7 Vendor: Nginx Software, Inc.
Release : 1.el6.ngx Build Date: Thu 20 Dec 2018 09:47:01 PM MSK
Install Date: (not installed) Build Host: centos6-amd64-builder-builder.gnt.nginx.com
Group : System Environment/Daemons Source RPM: unit-1.7-1.el6.ngx.src.rpm
Size : 708024 License: ASL 2.0
Signature : RSA/SHA1, Thu 20 Dec 2018 09:54:57 PM MSK, Key ID abf5bd827bd9bf62
Packager : Nginx Software, Inc. https://www.nginx.com
URL : https://unit.nginx.org/
Summary : NGINX Unit

unit.repo
[unit]
name=unit repo
baseurl=https://packages.nginx.org/unit/centos/$releasever/$basearch/
gpgcheck=0
enabled=1

[VBart]

@maksitop Thanks. It looks like only CentOS 6 64-bit package is broken. We're working on preparing a new one. Also we've improved our release procedures to avoid this in future.

[defanator]

CentOS 6 x86_64 updated packages are coming soon, I'll post an update here.