Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note about nginx for Windows beta version. #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

y82
Copy link
Collaborator

@y82 y82 commented Jul 11, 2024

No description provided.

@y82 y82 requested review from pluknet, arut, lcrilly and Maryna-f5 July 11, 2024 08:14

<section>

<para>
<note>
Currently nginx for Windows is available in a beta version
Copy link
Collaborator

@lcrilly lcrilly Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the 'beta' mention in the next paragraph be adjusted, too? There is no reason to mention beta more than once. It's good to lift it to the top of the article.

@oxpa
Copy link
Contributor

oxpa commented Jul 31, 2024

IMO, "beta version" assumes that the software will be released into a production version at some point. As we are not going to release nginx for windows any time soon, I suppose something like below would be better.

nginx is available for windows for local development and testing purposes. It is not meant to be used in a production environments but rather as an aid for windows based developers.

This wording clearly states the purpose of the windows build and doesn't promise any changes into it.

@lcrilly
Copy link
Collaborator

lcrilly commented Jul 31, 2024

FWIW, the Docker Hub readme says this

[nginx] also has a proof of concept port for Microsoft Windows.

@pluknet
Copy link
Collaborator

pluknet commented Aug 13, 2024

the page already contains all the necessary parts, note:

@pluknet
Copy link
Collaborator

pluknet commented Aug 13, 2024

the page already contains all the necessary parts, no need to further adjust it:

Due to this and some other known issues version of nginx for Windows is considered to be a beta version.

@pluknet pluknet closed this Aug 13, 2024
@lcrilly
Copy link
Collaborator

lcrilly commented Aug 13, 2024

It is not clear enough and many people seek production support for Windows. If nothing else, this page would still benefit from having the "beta version" phrase moved to the top of the article.

@y82 should be given the opportunity to respond before this is closed or resubmitted.

@lcrilly lcrilly reopened this Aug 13, 2024
@pluknet
Copy link
Collaborator

pluknet commented Aug 13, 2024

It is not clear actually how many people failed to read the existing (and emphasized) text, that's not our fault.
Changing it at someone's whim is a bad practice.

To reiterate: IMHO, the beta status is clearly enough articulated.
Given the PR name, this is also a bad change: a beta version status is already present, there's nothing to "add".

If ever change anything, we could move the existing "beta version" note to make it the 1st sentence, though I'd leave it as is.

For sure, it's up to @y82 to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants