Skip to content

Read Go build info from the binary #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

Read Go build info from the binary #276

merged 1 commit into from
Jul 12, 2022

Conversation

lucacome
Copy link
Contributor

With Go 1.18 it's possible to get git info from the binary, removing the need to inject values at build time.

@lucacome lucacome requested a review from a team July 11, 2022 19:14
@lucacome lucacome self-assigned this Jul 11, 2022
@lucacome lucacome requested review from ciarams87, jjngx and shaun-nx July 11, 2022 19:14
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 11, 2022
@lucacome lucacome merged commit 5481906 into main Jul 12, 2022
@lucacome lucacome deleted the chore/build-info branch July 12, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87 ciarams87 was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @jjngx