-
Notifications
You must be signed in to change notification settings - Fork 129
Use server side apply for NGF CRDs #3589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should note that with Helm, it does not run into the same client side apply issues as kubectl does so if a user were to deploy/install the CRDs with Helm there is no issue. Though if that same user wanted to update the CRDs after installation through Helm, they would be required to use |
This also means that all of our Functional tests and NFR tests that deploy NGF through Helm do not install the NGF CRDs through SSA, meaning NGF doesn't thoroughly test cases where the CRDs are SSA'd. I could foresee unknown errors occurring with users who SSA their CRDs as it seems like there are some logic and validation differences between SSA and CSA. However, some of those issues were from a few years ago when SSA wasn't as popular and widely adopted, so maybe most of the issues have been hammered out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3589 +/- ##
=======================================
Coverage 86.85% 86.85%
=======================================
Files 127 127
Lines 15266 15266
Branches 62 62
=======================================
+ Hits 13259 13260 +1
+ Misses 1853 1851 -2
- Partials 154 155 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6db6a34
to
aec0cf0
Compare
aec0cf0
to
08d1c3d
Compare
Proposed changes
Update docs and Makefile to use kubectl server side apply for NGF CRDs.
Problem: The NginxProxy CRD is getting too large for the normal client side kubectl apply to handle.
Solution: Update docs and Makefile to use kubectl server side apply for NGF CRDs.
Testing: Deployed NGF through manifests using server-side applied CRDs and manually ran through the policy examples and the cafe-example to make sure NGF still works.
Closes #3549
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.