Skip to content

Add nginxGateway.name usage in case of its presence instead of nameOverride #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

tataruty
Copy link
Contributor

Add nginxGateway.name usage in case of its presence instead of nameOverride

Proposed changes

As a user of NGF's Helm Charts
I want to use a nginxGateway.name to configure the names of my deployments
So that I don't have to use nameOverride to override the entire name.

Testing:

name = momo, nameOverride = overrrmi, releaseName = chart,  chart.name = nginx-gateway-fabric
result: chart-momo
proxy: momo-proxy-config
config: momo-config


name = chart, nameOverride = overrrmi, releaseName = chart, chart.name = nginx-gateway-fabric
result: chart
proxy: chart-proxy-config
config: chart-config


name =  , nameOverride = chart, releaseName = chart, chart.name = nginx-gateway-fabric
result: chart
proxy: chart-proxy-config
config: chart-config

name = momo, nameOverride = , releaseName = chart, chart.name = nginx-gateway-fabric
result: chart-momo
proxy: momo-proxy-config
config: momo-config

name = , nameOverride = overrrmi, releaseName = chart, chart.name = nginx-gateway-fabric
result: chart-overrrmi
proxy: overrrmi-proxy-config
config: overrrmi-config

name = , nameOverride = , releaseName = chart, chart.name = nginx-gateway-fabric
result: chart-nginx-gateway-fabric
proxy: chart-proxy-config
config: chart-config


name = , nameOverride = , releaseName = nginx-gateway-fabric, chart.name = nginx-gateway-fabric
result: nginx-gateway-fabric
proxy: nginx-gateway-fabric-proxy-config
config: nginx-gateway-fabric-config

 name = , nameOverride = nginx-gateway-fabric, releaseName = chart, chart.name = nginx-gateway-fabric
result: chart-nginx-gateway-fabric
proxy: nginx-gateway-fabric-proxy-config
config: nginx-gateway-fabric-config

name = nginx-gateway-fabric, nameOverride = , releaseName = chart, chart.name = nginx-gateway-fabric
result: chart-nginx-gateway-fabric
proxy: nginx-gateway-fabric-proxy-config
config: nginx-gateway-fabric-config

Closes #2490

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

N/A

Copy link

nginx-bot bot commented Jun 18, 2025

Hi @tataruty! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community label Jun 18, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests helm-chart Relates to helm chart labels Jun 18, 2025
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work! seems like some of the pipelines failed, might need to re-run those. They can be a bit flakey.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (3e261f3) to head (9204a55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3528      +/-   ##
==========================================
- Coverage   86.83%   86.79%   -0.04%     
==========================================
  Files         127      127              
  Lines       15079    15079              
  Branches       62       62              
==========================================
- Hits        13094    13088       -6     
- Misses       1835     1840       +5     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tataruty tataruty merged commit f8f5fb7 into main Jun 19, 2025
103 of 106 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 19, 2025
@tataruty tataruty deleted the helm/add_name_to_helm_chart branch June 19, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add nginxGateway.name in helm chart
4 participants