Skip to content

Add GKE router to nfr workflow #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Add GKE router to nfr workflow #3392

merged 4 commits into from
May 20, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented May 20, 2025

Add a small fix to the nfr workflow which involves creating a GKE router.

Passing nfr workflow action: https://github.com/nginx/nginx-gateway-fabric/actions/runs/15143764098

PR containing nfr workflow test results is here: #3391

@bjee19 bjee19 requested a review from a team as a code owner May 20, 2025 21:21
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (a8d373e) to head (f3c93e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
+ Coverage   86.77%   86.79%   +0.02%     
==========================================
  Files         129      129              
  Lines       14862    14862              
  Branches       62       62              
==========================================
+ Hits        12897    12900       +3     
+ Misses       1817     1815       -2     
+ Partials      148      147       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 force-pushed the chore/fix-nfr-workflow branch from 66d6f36 to f3c93e8 Compare May 20, 2025 23:05
@bjee19 bjee19 merged commit 6aed428 into main May 20, 2025
42 checks passed
@bjee19 bjee19 deleted the chore/fix-nfr-workflow branch May 20, 2025 23:30
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants