NFR Test Results for NGF version edge #3391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
bjee19
reviewed
May 20, 2025
There was a problem hiding this comment.
Seems like we are encountering a little bit of dropped traffic in some of our zero-downtime-scale tests.
bjee19
reviewed
May 20, 2025
|
|
||
| ### NGINX Error Logs | ||
| 2025/05/20 19:47:56 [emerg] 8#8: unexpected end of file, expecting ";" or "}" in /etc/nginx/conf.d/http.conf:1608 |
There was a problem hiding this comment.
These weird errors are showing up still, which we have communicated with the nginx agent team.
bjee19
force-pushed
the
chore/fix-nfr-workflow
branch
from
66d6f36 to
f3c93e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3391 +/- ##
==========================================
- Coverage 86.78% 86.75% -0.04%
==========================================
Files 129 129
Lines 14862 14862
Branches 62 62
==========================================
- Hits 12898 12893 -5
- Misses 1816 1820 +4
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with NFR test results for NGF version edge ["oss","plus"]