Skip to content

Update service labels in NFR tests #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Update service labels in NFR tests #3386

merged 2 commits into from
May 20, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented May 16, 2025

Problem: The GKE service label for nginx LB is not provided in the helm chart anymore.

Solution: Add the label in each Gateway infrastructure field.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: The GKE service label for nginx LB is not provided in the helm chart anymore.

Solution: Add the label in each Gateway infrastructure field.
@sjberman sjberman requested a review from a team as a code owner May 16, 2025 18:12
@github-actions github-actions bot added the tests Pull requests that update tests label May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (acf316c) to head (e7c633d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         129      129           
  Lines       14862    14862           
  Branches       62       62           
=======================================
+ Hits        12896    12897    +1     
+ Misses       1818     1817    -1     
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjberman sjberman enabled auto-merge (squash) May 20, 2025 21:02
@sjberman sjberman merged commit ee195fc into main May 20, 2025
42 checks passed
@sjberman sjberman deleted the tests/lb-annotation branch May 20, 2025 21:08
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants